fix: no IPFS_JS_EXEC during 1st pass of test-external #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures
IPFS_JS_EXEC
is ignored during the first run ofnpm test
intest-external
.It will work as expected during the second time
npm test
is run.Motivation
We want to run ipfs-webui tests in ipfs/js-ipfs#2706,
however, for some reason E2E tests do not use the
ipfs
fromfile:*.tgz
defined inpackage.json
.I am not sure what is happening exactly,
connect-deps
does not do the trick, only settingIPFS_JS_EXEC
works. Either way, this seems to be a useful fix to merge anyway, as it removes potential side effect from initial pass.cc @hugomrdias